Add support for RHEL8 #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds support for running this application on RHEL8. The fabfile.py configuration and deployment scripts are simplified; RHEL8 includes Python 3.6 so we no longer need to install it, nor a different version of SQLite. We can also use Node 18 instead of Node 16. The Python application code also needs to be modified to use a more secure version of hashlib.md5 to comply with FIPS mode. See http://blog.serindu.com/2019/11/12/django-in-fips-mode/ for background and the implemented workaround.
contolini
approved these changes
Feb 12, 2024
fabfile.py
Outdated
| # Node 18 doesn't seem to work on RHEL 7. | ||
| # https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V18.md#toolchain-and-compiler-upgrades | ||
| NODE_VERSION = "16" | ||
| NODE_VERSION = "18" |
There was a problem hiding this comment.
Can we use Node 20 or is that crazy talk?
There was a problem hiding this comment.
Not crazy at all, I will try it.
chosak
added a commit
that referenced
this pull request
Oct 4, 2024
PR 89 migrated the EC2 deployment configuration for this repository to RHEL8. Those changes included some explicit monkeypatching of MD5 to allow for running on RHEL8 with FIPS mode enabled. Going forward, support for EC2 deployment will be maintained in the ec2 branch [1] until such time as we are fully containerized. For that reason, we no longer need to maintain this code in the main branch, and it can be removed. [0] #89 [1] https://github.com/cfpb/website-indexer/tree/ec2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support for running this application on RHEL8.
The fabfile.py configuration and deployment scripts are simplified; RHEL8 includes Python 3.6 so we no longer need to install it, nor a different version of SQLite. We can also use Node 18 instead of Node 16.
The Python application code also needs to be modified to use a more secure version of hashlib.md5 to comply with FIPS mode. See http://blog.serindu.com/2019/11/12/django-in-fips-mode/ for background and the implemented workaround.
I've already tested this manually in our internal cloud environment; see internal CFGOV/crawler-deploy#2 for the associated CloudFormation template changes.